[#DWR-83] Possible resource leak in org.directwebremoting.servlet.FileHandler.handle - DWR

Details

Type: Bug
Status: Resolved
Priority: Trivial
Resolution: Fixed
Affects Version/s: 2.0, 2.0.1, 2.0.2, 2.0.3
Fix Version/s: 2.0.4, 3.0.M1
Component/s: Core

Description:

org.directwebremoting.servlet.FileHandler.handle opens an input stream, but does not close it.

Issue Links

Duplicate

This issue is duplicated by:
~~DWR-550~~ Input stream not getting closed in DWR and hence getting hepdumps.

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Mike Wilson added a comment - 11/Apr/08 7:24 PM

This needs to be fixed for the 2.0 branch as well. The streams 'in' and 'raw' need to be closed in FileHandler.handle.
Do you want me to fix it?
//Mike

Show

Mike Wilson added a comment - 11/Apr/08 7:24 PM This needs to be fixed for the 2.0 branch as well. The streams 'in' and 'raw' need to be closed in FileHandler.handle. Do you want me to fix it? //Mike

Hide

Permalink

Joe Walker added a comment - 17/Apr/08 5:55 PM

I had a look because I thought it was just a close not called in finally problem, but it was a close not called problem. I fixed it. I also found a similar problem in 3.

Show

Joe Walker added a comment - 17/Apr/08 5:55 PM I had a look because I thought it was just a close not called in finally problem, but it was a close not called problem. I fixed it. I also found a similar problem in 3.

Hide

Permalink

Mike Wilson added a comment - 25/Apr/08 12:10 PM

A colleague just verified in test that it is fixed now.

Show

Mike Wilson added a comment - 25/Apr/08 12:10 PM A colleague just verified in test that it is fixed now.

People

Assignee:

Joe Walker

Reporter:

Ilya Perminov
Votes:

0

Watchers:

0

Dates

Created:

26/Apr/07 9:56 PM

Updated:

01/Nov/11 1:05 PM

Resolved:

25/Apr/08 12:10 PM